Skip to content

Code Reviews

Status: ⏳ PENDING

The inverse of this chapter's rules — practices to recognize and avoid. Each will get a junior-level definition, a real example of the harm it causes, and the clean alternative.

Anti-Patterns to Cover

  • Rubber-stamp approval (LGTM without reading the diff)
  • Bikeshedding on style after a formatter is in place
  • Nitpick-only reviews that miss the architectural issue
  • Personal-attack tone instead of code-focused critique
  • Blocking on subjective preferences ("I would write it differently")
  • Mega-PRs (1000+ lines) where no reviewer can catch real bugs
  • Author defensiveness — arguing instead of asking "what would convince you?"
  • Review ping-pong — endless rounds because the author and reviewer never sync

See the chapter README for the positive rules.